Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential histograms support for the prometheus exporter #5210

Closed
nicu-da opened this issue Feb 13, 2023 · 2 comments
Closed

Exponential histograms support for the prometheus exporter #5210

nicu-da opened this issue Feb 13, 2023 · 2 comments
Labels
Feature Request Suggest an idea for this project

Comments

@nicu-da
Copy link

nicu-da commented Feb 13, 2023

Is your feature request related to a problem? Please describe.
The specification recently added conversions for exponential histograms into prometheus histograms (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#exponential-histograms).
This is not supported as of yet by the java implementation, leading to exponential histograms being dropped when using prometheus https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Serializer.java#L110

Describe the solution you'd like
Exponential histograms are converted to the prometheus metric format as specified in the specification.

@nicu-da nicu-da added the Feature Request Suggest an idea for this project label Feb 13, 2023
@jkwatson
Copy link
Contributor

Are you able to contribute the work to make this happen? Thanks!

@nicu-da
Copy link
Author

nicu-da commented Feb 20, 2023

Started looking at this, realized that the native histogram support in promtheus is still experimental and only supported in the protobuf read/write format and not yet standardized for the text format, therefore this change cannot be feasibly be implemented until Prometheus defines the text format for native histograms.
Will be closing this until the text format for native histograms is defined by prometheus.

@nicu-da nicu-da closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

2 participants