Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus unit suffixes are not applied to TYPE and HELP #5716

Closed
dashpole opened this issue Aug 16, 2023 · 0 comments · Fixed by #5718
Closed

Prometheus unit suffixes are not applied to TYPE and HELP #5716

dashpole opened this issue Aug 16, 2023 · 0 comments · Fixed by #5718
Labels
Bug Something isn't working

Comments

@dashpole
Copy link
Contributor

Describe the bug

I noticed in the unit test for prometheus:

+ "# TYPE non_monotonic_cumulative_double_sum gauge\n"
+ "# HELP non_monotonic_cumulative_double_sum description\n"
+ "non_monotonic_cumulative_double_sum_seconds{otel_scope_name=\"full\",otel_scope_version=\"version\",type=\"nmcds\"} 5.0 1633950672.000\n"

+ "# TYPE non_monotonic_cumulative_double_sum gauge\n"
+ "# HELP non_monotonic_cumulative_double_sum description\n"
+ "non_monotonic_cumulative_double_sum_seconds{otel_scope_name=\"full\",otel_scope_version=\"version\",type=\"nmcds\"} 5.0 1633950672000\n"

I expect to see unit suffixes on TYPE and HELP comments as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant