Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EventEmitter to EventLogger #6290

Closed
jack-berg opened this issue Mar 12, 2024 · 0 comments · Fixed by #6316
Closed

Rename EventEmitter to EventLogger #6290

jack-berg opened this issue Mar 12, 2024 · 0 comments · Fixed by #6316
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

jack-berg commented Mar 12, 2024

Our EventEmitter class is currently out of alignment with the spec, which calls the interface EventLogger instead. I attempted algin the naming with the spec in #4961, but punted after receiving pushback from the java SIG.

There was a recent attempt to rename EventLogger to EventEmitter in the spec, and after a long debate which included the spec SIG in addition to the event SIG, folks ultimately agreed on EventLogger.

The time is right for opentelemetry-java to align naming with the spec and rename EventEmitter to EventLogger. As discussed here, we should try to do this before the next release to bundle several breaking changes to the event API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant