Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

fix: align globalThis fallbacks with otel-core #126

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

legendecas
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #126 (c3de0f8) into main (50db1c2) will decrease coverage by 0.64%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   95.11%   94.46%   -0.65%     
==========================================
  Files          42       42              
  Lines         573      578       +5     
  Branches       90       94       +4     
==========================================
+ Hits          545      546       +1     
- Misses         28       32       +4     
Impacted Files Coverage Δ
src/platform/browser/globalThis.ts 33.33% <33.33%> (-66.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50db1c2...c3de0f8. Read the comment docs.

@legendecas
Copy link
Member Author

Linter complaints should be able to be fixed by #127.

@vmarchaud
Copy link
Member

@dyladan If you are good with this we can merge this one and #127 after ?

@vmarchaud vmarchaud merged commit 3507de7 into open-telemetry:main Nov 8, 2021
@legendecas legendecas deleted the globalthis branch November 8, 2021 14:46
@vmarchaud vmarchaud added internal bug Something isn't working and removed internal labels Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants