Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

feat: deprecate Sampler #166

Merged
merged 2 commits into from
Aug 9, 2022
Merged

feat: deprecate Sampler #166

merged 2 commits into from
Aug 9, 2022

Conversation

legendecas
Copy link
Member

Preferring the one declared in @opentelemetry/sdk-trace-base.

Fixes: #148
Related: open-telemetry/opentelemetry-js#3088

Preferring the one declared in @opentelemetry/sdk-trace-base
@legendecas legendecas requested a review from a team as a code owner July 12, 2022 03:29
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #166 (0d125e7) into main (17ccb3a) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d125e7 differs from pull request most recent head 4cb6476. Consider uploading reports for the commit 4cb6476 to get more accurate results

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          45       45           
  Lines         650      650           
  Branches      102      102           
=======================================
  Hits          619      619           
  Misses         31       31           
Impacted Files Coverage Δ
src/trace/SamplingResult.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dyladan
Copy link
Member

dyladan commented Aug 9, 2022

feat updates the minor version. Is that what we want?

@legendecas
Copy link
Member Author

feat updates the minor version. Is that what we want?

Yes, this is intended. This is not breaking but introducing something new for SDKs to implement.

@dyladan dyladan merged commit 313b2e2 into open-telemetry:main Aug 9, 2022
@legendecas legendecas deleted the sampler branch August 10, 2022 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampler and SamplingResult interfaces and implementations in SDK
4 participants