Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Consider not exposing type + singleton #38

Closed
carlosalberto opened this issue Apr 20, 2021 · 0 comments · Fixed by #46
Closed

Consider not exposing type + singleton #38

carlosalberto opened this issue Apr 20, 2021 · 0 comments · Fixed by #46
Assignees
@dyladan

Comments

@carlosalberto
Copy link

A few components have both their type + singleton exported, e.g. NOOP_TEXT_MAP_PROPAGATOR and NoopTextMapPropagator (likewise for NoopTracer, NoopTracerProvider, etc). Unless there's a technical reason to do this on purpose, I'd suggest exposing one or the another, in order to prevent confusion.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dyladan dyladan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: do not export singletons dyladan/opentelemetry-js-api
2 participants
@carlosalberto @dyladan