Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrumentation restify: support new versions #1339

Closed
blumamir opened this issue Jan 1, 2023 · 6 comments · Fixed by #1576
Closed

instrumentation restify: support new versions #1339

blumamir opened this issue Jan 1, 2023 · 6 comments · Fixed by #1576

Comments

@blumamir
Copy link
Member

blumamir commented Jan 1, 2023

current restify instrumentation supports the following range

export const SUPPORTED_VERSIONS = ['>=4.0.0 <9'];

and tav is configured with

restify:
  versions: "4.3.4 || 5.2.0 || 6.4.0 || 7.7.0 || ^8.4.0"
  commands: npm run test

There are new versions of restify that will not be instrumented (9.0.0, 10.0.0) which needs to be added to the supported and tested versions (and verified they also work).

Renovate tried to bump the version in #1317 but there are other code changes that needs to be done.

This issue is for adding support for newer restify versions

@blumamir blumamir added up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue labels Jan 1, 2023
@blumamir
Copy link
Member Author

blumamir commented Jan 1, 2023

@types/restify is also very old, and the renovate PR to bump it #1292 failed with message:

lerna ERR! lifecycle "prepare" errored in "@opentelemetry/instrumentation-restify", exiting 1

The types should also be aligned as part of this issue

@kirrg001
Copy link
Contributor

FYI restify v8 does not work with Node v18. Support was added in restify v10.
restify/node-restify#1925

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 1, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
@kirrg001
Copy link
Contributor

kirrg001 commented Jun 7, 2023

Can we please re-open this issue?

@pichlermarc
Copy link
Member

pichlermarc commented Jul 12, 2023

Can we please re-open this issue?

Yes, I think #1576 would take care of this. 🙂

@pichlermarc pichlermarc reopened this Jul 12, 2023
@pichlermarc pichlermarc removed up-for-grabs Good for taking. Extra help will be provided by maintainers stale labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants