-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for fastify #41
Comments
Thanks for opening this. I marked it as up-for-grabs for now. If you are feeling motivated, maybe you can attempt to write solution and open a PR. |
@PatrickHeneise Hi - I was wondering if there have been any updates on this. Thanks! |
Haven't had a chance yet. @mayurkale22 how would I start on this? And, if I add fastify, how does it make it's way into Google Trace? |
@PatrickHeneise I would take a look at some of the node plugins in this repo to get an idea how they work, but generally we use |
For the plugin, you could refer to the implementation done by datadog here: https://github.com/DataDog/dd-trace-js/tree/master/packages/datadog-plugin-fastify/src |
It looks like someone has already written a library connecting fastify to OpenTelemetry here: https://github.com/mkinoshi/fastify-opentelemetry |
Both approaches likely have value, but it may be better to spend time elsewhere if there is already a good way to get spans from fastify. |
We recently published a fastify plugin that utilizes |
Thanks for the suggestion @dyladan 😎 - just opened a PR -> open-telemetry/opentelemetry.io#241 |
@dyladan Do we want to keep this issue open since there are multiple solutions available ? |
Support for |
Is your plugin request related to a problem? Please describe.
We'd like to use the gcloud trace agent in our software which is runs on fastify. Fastify uses a similar API to express, I was hoping this would work out of the box, but unfortunately that's not the case.
Is it applicable for Node or Browser or both
Additional context
Original issue: googleapis/cloud-trace-nodejs#1167 (comment)
The text was updated successfully, but these errors were encountered: