Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fastify and browser autoinjection failed to compile #793

Merged
merged 5 commits into from Dec 22, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 21, 2021

Fastify: a type update in a dependency caused the instrumentation to fail to compile

browser autoinjection: mixed 0.26.x and 0.27.x core dependencies caused the package to fail to compile.

@dyladan dyladan requested a review from a team as a code owner December 21, 2021 18:21
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #793 (8593f58) into main (e3ce102) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   94.90%   95.37%   +0.46%     
==========================================
  Files          13       28      +15     
  Lines         707     1318     +611     
  Branches      142      197      +55     
==========================================
+ Hits          671     1257     +586     
- Misses         36       61      +25     
Impacted Files Coverage Δ
...njection/src/instrumentation/WebInstrumentation.ts 97.22% <100.00%> (ø)
...er-extension-autoinjection/test/background.test.ts 100.00% <0.00%> (ø)
...strumentation-fastify/test/instrumentation.test.ts 96.88% <0.00%> (ø)
...extension-autoinjection/test/contentScript.test.ts 100.00% <0.00%> (ø)
...ction/src/contentScript/InstrumentationInjector.ts 100.00% <0.00%> (ø)
...metry-browser-extension-autoinjection/src/types.ts 90.32% <0.00%> (ø)
...telemetry-instrumentation-fastify/src/constants.ts 100.00% <0.00%> (ø)
...tension-autoinjection/test/instrumentation.test.ts 100.00% <0.00%> (ø)
...try-instrumentation-fastify/src/instrumentation.ts 97.29% <0.00%> (ø)
... and 6 more

@@ -71,9 +71,9 @@
"@opentelemetry/exporter-otlp-http": "0.26.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be also outdated

@vmarchaud vmarchaud merged commit c08efa8 into open-telemetry:main Dec 22, 2021
@Flarna Flarna deleted the fix-compilation branch February 9, 2022 22:47
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants