Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongodb4): added mongodb4 instrumentation #869

Merged

Conversation

osherv
Copy link
Member

@osherv osherv commented Feb 6, 2022

New PR after CLA fix

@osherv osherv requested a review from a team as a code owner February 6, 2022 10:57
@vmarchaud vmarchaud added the enhancement New feature or request label Feb 6, 2022
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #869 (a6408bc) into main (fbceaf8) will decrease coverage by 6.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   95.29%   89.18%   -6.12%     
==========================================
  Files          10       13       +3     
  Lines         701      989     +288     
  Branches      142      217      +75     
==========================================
+ Hits          668      882     +214     
- Misses         33      107      +74     
Impacted Files Coverage Δ
...opentelemetry-instrumentation-mongodb/src/types.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)
...try-instrumentation-mongodb/src/instrumentation.ts 68.93% <0.00%> (ø)

@osherv
Copy link
Member Author

osherv commented Feb 6, 2022

This pr is a continuation of: #794

@osherv osherv requested a review from blumamir February 6, 2022 12:20
@vmarchaud vmarchaud linked an issue Feb 7, 2022 that may be closed by this pull request
@vmarchaud
Copy link
Member

@osherv Could you rebase the PR so we can merge this ? Thanks !

@osherv
Copy link
Member Author

osherv commented Feb 9, 2022

Done! Thanks :) @vmarchaud

@blumamir blumamir merged commit 47700e1 into open-telemetry:main Feb 9, 2022
@osherv osherv deleted the feat/add-mongodb4-instrumentation-new branch February 9, 2022 17:36
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(mongodb-instrumentation): support mongodb v4
4 participants