Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser-extension-autoinjection): update eslint-plugin-json5 version to 0.1.4 #896

Merged
merged 1 commit into from Feb 14, 2022

Conversation

haddasbronfman
Copy link
Member

update eslint-plugin-json5 to 0.1.4 which support eslint v8

Which problem is this PR solving?

This problem: which happened when I 'npm install' from root

lerna info versioning independent
lerna info Bootstrapping 45 packages
lerna info Installing external dependencies
lerna ERR! npm install exited 1 in '@opentelemetry/browser-extension-autoinjection'
lerna ERR! npm install stderr:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @opentelemetry/browser-extension-autoinjection@0.27.3
npm ERR! Found: eslint@8.7.0
npm ERR! node_modules/eslint
npm ERR! dev eslint@"8.7.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0" from eslint-plugin-json5@0.1.3
npm ERR! node_modules/eslint-plugin-json5
npm ERR! dev eslint-plugin-json5@"0.1.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Short description of the changes

I updated the 'eslint-plugin-json5' version to be 0.1.4
This version supports eslint v8.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@haddasbronfman haddasbronfman requested a review from a team as a code owner February 14, 2022 15:55
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix

@haddasbronfman haddasbronfman changed the title fix(eslint-version): update eslint-plugin-json5 version to 0.1.4 fix(browser-extension-autoinjection): update eslint-plugin-json5 version to 0.1.4 Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #896 (2cd744a) into main (adbd6dc) will decrease coverage by 0.58%.
The diff coverage is n/a.

❗ Current head 2cd744a differs from pull request most recent head 3a37db5. Consider uploading reports for the commit 3a37db5 to get more accurate results

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   95.29%   94.71%   -0.59%     
==========================================
  Files          10       16       +6     
  Lines         701      813     +112     
  Branches      142      162      +20     
==========================================
+ Hits          668      770     +102     
- Misses         33       43      +10     
Impacted Files Coverage Δ
...njection/src/instrumentation/WebInstrumentation.ts 97.22% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...ction/src/contentScript/InstrumentationInjector.ts 100.00% <0.00%> (ø)
...rc/background/ProgrammaticContentScriptInjector.ts 100.00% <0.00%> (ø)
...metry-browser-extension-autoinjection/src/types.ts 90.32% <0.00%> (ø)

@dyladan dyladan merged commit e47fcaa into open-telemetry:main Feb 14, 2022
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants