Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-instrumentation-aws-sdk): error when ReturnConsumedCapacity is set to None #899

Merged
merged 11 commits into from Feb 28, 2022

Conversation

pauloprestes
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • check if function map exists on ConsumedCapacity property.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@pauloprestes pauloprestes requested a review from a team as a code owner February 15, 2022 03:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 15, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for the fix

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #899 (b2c5c00) into main (f436601) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #899    +/-   ##
========================================
  Coverage   95.91%   95.91%            
========================================
  Files          13       23    +10     
  Lines         856     1346   +490     
  Branches      178      280   +102     
========================================
+ Hits          821     1291   +470     
- Misses         35       55    +20     
Impacted Files Coverage Δ
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)
... and 1 more

@blumamir
Copy link
Member

@pauloprestes please run npm run lint:fix, thanks

@blumamir blumamir merged commit e7ab4d0 into open-telemetry:main Feb 28, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/instrumentation-aws-sdk fails when using BatchGetItem with ReturnConsumedCapacity set to NONE
4 participants