Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mysql2 responsehook #915

Merged
merged 5 commits into from Feb 27, 2022

Conversation

nozik
Copy link
Contributor

@nozik nozik commented Feb 21, 2022

Which problem is this PR solving?

  • Adding support for a responseHook, that enables collecting the query result.

Short description of the changes

  • Add a responseHook config, and add tests to verify its behavior.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@nozik nozik requested a review from a team as a code owner February 21, 2022 19:42
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #915 (2f57d28) into main (2229cbe) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   95.91%   96.10%   +0.19%     
==========================================
  Files          13       16       +3     
  Lines         856     1001     +145     
  Branches      178      204      +26     
==========================================
+ Hits          821      962     +141     
- Misses         35       39       +4     
Impacted Files Coverage Δ
...etry-instrumentation-mysql2/src/instrumentation.ts 95.52% <100.00%> (ø)
.../opentelemetry-instrumentation-mysql2/src/utils.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)

@blumamir
Copy link
Member

blumamir commented Feb 27, 2022

@nozik I think this is ready to be merged.
please rebase the PR, or Allowing changes to a pull request branch created from a fork so maintainers can rebase before merging

@nozik
Copy link
Contributor Author

nozik commented Feb 27, 2022

@blumamir Thanks, it's now rebased. For some reason I'm not seeing the option in the link you've shared, I discussed that with Rauno as well. Anyway, feel free to merge.

@blumamir
Copy link
Member

Thanks! sorry, I just merged another PR to main, can you please rebase again?

@nozik
Copy link
Contributor Author

nozik commented Feb 27, 2022

@blumamir 👍

@blumamir blumamir merged commit f436601 into open-telemetry:main Feb 27, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
@rauno56 rauno56 deleted the add_mysql2_responsehook branch March 9, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants