Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable direct reconciliation of the v1beta1 types #2620

Closed
jaronoff97 opened this issue Feb 12, 2024 · 3 comments · Fixed by #2703
Closed

Enable direct reconciliation of the v1beta1 types #2620

jaronoff97 opened this issue Feb 12, 2024 · 3 comments · Fixed by #2703
Labels
area:collector Issues for deploying collector enhancement New feature or request

Comments

@jaronoff97
Copy link
Contributor

Component(s)

collector

Is your feature request related to a problem? Please describe.

The operator should add the v1alpha2 types to its known schemas

Describe the solution you'd like

Add it to the scheme

Describe alternatives you've considered

No response

Additional context

No response

@jaronoff97 jaronoff97 added the enhancement New feature or request label Feb 12, 2024
@jaronoff97 jaronoff97 added this to the v1alpha2 CRD release milestone Feb 12, 2024
@pavolloffay
Copy link
Member

I have started looking into this:

  • add conversion webhook
  • include v1alpha2 CRD in the bundle and manifests
  • add v1alpha2 to reconciliation

@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Feb 14, 2024
@pavolloffay
Copy link
Member

Note when v1alpha2 is enabled we run into

The CustomResourceDefinition "opentelemetrycollectors.opentelemetry.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

In the past it was solved with #1981 (comment) to trim the CRD description.

This happens with kubectl apply as it stores the last version in the annotations that has a limited size. The problem does not occur with kubectl create|replace commands.

@pavolloffay
Copy link
Member

pavolloffay commented Feb 14, 2024

The setting description size to 0 fixed the issue.

Notes:

  • k get otelcol.v1alpha1.opentelemetry.io and k get otelcol.v1beta1.opentelemetry.io
  • // +kubebuilder:unservedversion - not serve the version
  • // +kubebuilder:storageversion - only a single version is storage version. When an object is written, it is stored at the version designated as the storage version at the time of the write

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#previous-storage-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
2 participants