Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagated annotations causes issues for Deployment, StatefulSet and DaemonSet #2627

Closed
ryanohnemus opened this issue Feb 14, 2024 · 0 comments · Fixed by #2692
Closed

Propagated annotations causes issues for Deployment, StatefulSet and DaemonSet #2627

ryanohnemus opened this issue Feb 14, 2024 · 0 comments · Fixed by #2692
Assignees
Labels
bug Something isn't working needs triage

Comments

@ryanohnemus
Copy link

ryanohnemus commented Feb 14, 2024

Component(s)

operator

What happened?

Description

I am running into a repeat of #605, but for annotations instead. Annotation changes on the OpenTelemetryCollector Custom Resource cause the deployment (etc) to be updated with this annotation (which is changing the template) and will cause opentelemetry resources to restart.

Can the work that was completed for adding labelsFilter also be completed for annotations via an annotationsFilter so that these do not propagate to the Deployment (etc) resources that are being created?

This is especially troublesome for k8s deployments that use a form of configuration sync that applies an annotation to all resources to specify the latest version they were synced from, such as google's anthos config-sync which applies a configmanagement.gke.io/token annotation each time config (related or unrelated to the OpenTelemetryCollector CR) is updated.

Steps to Reproduce

Add any annotation to an OpenTelemetryCollector CR that use mode: deployment and your deployments will restart.

Expected Result

A way to filter out which annotations are propagated to the managed resource similar to labelsFilter.

Actual Result

No filtering available, so deployments are restarted when annotations are updated.

Kubernetes Version

1.28.1

Operator version

0.92.0

Collector version

0.92.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

@ryanohnemus ryanohnemus added bug Something isn't working needs triage labels Feb 14, 2024
@yuriolisa yuriolisa self-assigned this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants