Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Naming_CONVENTIONS for enum values #131

Closed
Oberon00 opened this issue Mar 17, 2020 · 3 comments
Closed

Inconsistent Naming_CONVENTIONS for enum values #131

Oberon00 opened this issue Mar 17, 2020 · 3 comments
Labels
release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:logs spec:metrics spec:traces
Projects
GA Spec Burndown

Comments

@Oberon00
Copy link
Member

Looking at

opentelemetry-proto/opentelemetry/proto/trace/v1/trace.proto

Line 106 in e76584d

SPAN_KIND_UNSPECIFIED = 0;

vs

opentelemetry-proto/opentelemetry/proto/trace/v1/trace.proto

Line 239 in e76584d

InvalidArgument = 3;

it seems we need to decide on a convention to follow when naming enum values.
@tigrannajaryan
Copy link
Member

Same discrepancy in the spec that describes the corresponding enums :-)
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-tracing.md#statuscanonicalcode

See SpanKind vs StatusCanonicalCode in the spec.

@bogdandrutu
Copy link
Member

It will be good to fix this in both specs and here.

@bogdandrutu bogdandrutu added release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:logs spec:metrics spec:traces labels Jul 30, 2020
This was referenced Aug 6, 2020
Merged
Merged
Merged
@bogdandrutu
Copy link
Member

The proto part is done.

@andrewhsu andrewhsu added this to Required/Allowed for GA, resolved. in GA Spec Burndown Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:logs spec:metrics spec:traces
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Oberon00 @bogdandrutu @tigrannajaryan