Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving start_time_unixnano to timeseries #38

Closed
tigrannajaryan opened this issue Nov 4, 2019 · 4 comments
Closed

Consider moving start_time_unixnano to timeseries #38

tigrannajaryan opened this issue Nov 4, 2019 · 4 comments

Comments

@tigrannajaryan
Copy link
Member

start_time_unixnano is likely going to be the same for all data point in timeseries. Moving this to timeseries message instead of putting it in the value (as it is now) will be a space and speed optimization.

@jmacd
Copy link
Contributor

jmacd commented Nov 4, 2019

I've wondered about this too. If you were collecting metrics over a large interval, especially for measure metrics, you would probably want individual timestamps, which is what OpenMetrics has specified. However it's wasteful in an SDK where you expect to export frequently. I'd leave both as options. OpenMetrics allows the timestamp to be omitted, in which case the backend uses its own, but I would prefer it to be an explicit field associated with the whole report.

@tigrannajaryan
Copy link
Member Author

@bogdandrutu any thoughts on this? You mentioned we never even reset the timestamps in the SDK currently.

@SergeyKanzhelev
Copy link
Member

If we will want to have this field on time series later we can always add it, correct? Should we close this issue for now?

@tigrannajaryan
Copy link
Member Author

Yes, let's close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants