Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable health-check in the proto #418

Closed
anelson-splunk opened this issue Aug 2, 2022 · 2 comments
Closed

Enable health-check in the proto #418

anelson-splunk opened this issue Aug 2, 2022 · 2 comments

Comments

@anelson-splunk
Copy link

Enhancement: There should be a way to check the health of a gRPC service via a health check. This would be a great way for Kubernetes to determine of a container serving gRPC is available to handle requests before actually sending requests to the pod. It would also be helpful in an architecture that might have gRPC services behind a load balancer so that the load balancer knows the service is healthy before sending requests to the gRPC service.
https://github.com/grpc/grpc/blob/master/doc/health-checking.md

@tigrannajaryan
Copy link
Member

What exactly enhancement is needed in OTLP? Isn't https://github.com/grpc/grpc/blob/master/doc/health-checking.md sufficient as a health check specification for any service that happens to receive OTLP?

@anelson-splunk
Copy link
Author

Never-mind - my enhancement went to the wrong repository... I meant for it to go in https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver to add to the receiver a health check using the gRPC specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants