Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogRecord.flags name is unclear. #422

Closed
bogdandrutu opened this issue Aug 8, 2022 · 1 comment
Closed

LogRecord.flags name is unclear. #422

bogdandrutu opened this issue Aug 8, 2022 · 1 comment
Assignees
@tigrannajaryan
Milestone
Declare OTLP 1.0

Comments

@bogdandrutu
Copy link
Member

When I read the field name flags my mind thought about flags related to the log property and not the "TraceFlags". I would suggest if still possible to use a better name like "trace_flags".
@bogdandrutu bogdandrutu added this to the Declare OTLP 1.0 milestone Aug 8, 2022
@bogdandrutu
Copy link
Member Author

I think, the name is correct, since only a part of the flags are TraceFlags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
Declare OTLP 1.0
Development

No branches or pull requests
2 participants
@bogdandrutu @tigrannajaryan