Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we intend to support non-number values for Gauges? #428

Closed
bogdandrutu opened this issue Sep 16, 2022 · 5 comments
Closed

Do we intend to support non-number values for Gauges? #428

bogdandrutu opened this issue Sep 16, 2022 · 5 comments
Labels
wontfix This will not be worked on

Comments

@bogdandrutu
Copy link
Member

If yes, then I think we should change Gauge DataPoints to be a different message than "NumberDataPoint". That will allow us to diverge from Sum. This is not a breaking change for the wire protocol (neither proto nor json), but breaks things like collector pdata, etc.

I think we should make a decision asap here, so we don't block Collector Pdata 1.0 release.

@tigrannajaryan
Copy link
Member

Do we intend to support non-number values for Gauges?

What non-number values are you envisioning? Things like enumerations to represent a state, e.g. (idle, running, stopped)? Or something else?

@jmacd
Copy link
Contributor

jmacd commented Sep 19, 2022

I do not support non-numeric gauge points. There is an existing convention for "info" metrics from OpenMetrics which are 1-valued, where you may put all sorts of values as attributes.

@bogdandrutu
Copy link
Member Author

@tigrannajaryan

Enums is an example, others may be "String" (i've seen this in stackdriver). I am not suggesting to do it, just want to make sure we understand the implication.

@pirgeo
Copy link
Member

pirgeo commented Sep 21, 2022

In the semantic conventions, we have been using an Attribute to solve the Enum use-case in the past. If we really need such a data type, we can always add it as a separate datatype in a non-breaking way later. My vote is to keep the gauge value number only.

@tigrannajaryan
Copy link
Member

I think we should use attributes for such use cases. Alternatively, it should be an event (LogRecord). Yet another alternate is to record this as an Entity and its attribute (Entity is a possible future new signal type).

I am closing this as "won't do". Please feel free to reopen if you think we still need it.

@tigrannajaryan tigrannajaryan added the wontfix This will not be worked on label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants