Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version identification to the opentelemetry-proto tar archive #434

Open
marcalff opened this issue Oct 28, 2022 · 1 comment
Open

Add version identification to the opentelemetry-proto tar archive #434

marcalff opened this issue Oct 28, 2022 · 1 comment

Comments

@marcalff
Copy link
Member

marcalff commented Oct 28, 2022

Please add a VERSION file in the source repository itself, so it gets included in the opentelemetry-proto.tar.gz archive.

When using the *.tar.gz file produced in the release:

https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/v0.19.0.tar.gz

the archive is named v0.19.0, sure, but there is no way (*) to inspect the content programmatically to confirm the code is for release 0.19.0

This is important, when someone wants to make a build using:
OPENTELEMETRY_PROTO_PATH=/path/to/opentelemetry-proto (where "a" tar.gz has been installed ... which one ?)
instead of pulling from github with a tag.

Please make the file easy to parse by makefiles, for example:

OPENTELEMETRY_PROTO_VERSION_STRING=0.19.0
OPENTELEMETRY_PROTO_VERSION_MAJOR=0
OPENTELEMETRY_PROTO_VERSION_MINOR=19
OPENTELEMETRY_PROTO_VERSION_PATCH=0

Please adjust RELEASING.md accordingly, so this version is maintained up to date.

(*) Parsing the change log is not an option here.

@tigrannajaryan
Copy link
Member

Is this a common practice with repos?

@open-telemetry/specs-approvers thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants