-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why TraceID and SpanID are defined []byte type? #500
Comments
Are you asking about why the particular design choice was made in OTLP? The answer to that is that it was found to be the best fit for design goals: https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/design-goals.md If you are asking what should be OTLP/JSON representation of trace id and span id see https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#json-protobuf-encoding |
Yes. So how trace id and span id in the output in expamle are not encoded? |
Examples are correct. trace id and span id are hex encoded. See the spec: https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#json-protobuf-encoding |
@Lempossible Has this been clarified? I feel we can close this issue already. |
When I'm useing json.Marshal(tradeData), the trace_id, span_id and parent_span_id in output are base64 encoded.
So I wonder why TraceID and SpanID are defined []byte type?
The text was updated successfully, but these errors were encountered: