Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide guidance for consistent instrumentation name #1035

Open
codeboten opened this issue Apr 6, 2022 · 0 comments
Open

Provide guidance for consistent instrumentation name #1035

codeboten opened this issue Apr 6, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation instrumentation

Comments

@codeboten
Copy link
Contributor

Currently just about every instrumentation library uses __name__ as its instrumentation name. It would be good to provide guidance in the contributing documentation around what parameter should be used here.

Are we recommending a single name for all the modules/classes in an instrumentation or are we ok with different instrumentation names for different modules within the same instrumentation library?

This is to clarify: #1012 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @srikanthccv