Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instrumentation-django] - empty span name #1098

Closed
shaykeren opened this issue May 19, 2022 · 2 comments · Fixed by #1788
Closed

[instrumentation-django] - empty span name #1098

shaykeren opened this issue May 19, 2022 · 2 comments · Fixed by #1788
Labels
bug Something isn't working

Comments

@shaykeren
Copy link

shaykeren commented May 19, 2022

Describe your environment
opentelemetry-instrumentation-django==0.30b1
django==4.0.4

Steps to reproduce
Having the following URL patterns:
`from django.urls import path
from . import views

urlpatterns = [
path('', views.index, name='index'),
path('list', views.list, name='list'),
]`
Please note that the path route has an empty value.

What is the expected behavior?
The expected behavior is not having an empty span name for this endpoint.
Also, consider returning http.route attribute with value '/'

What is the actual behavior?

  • Got an empty span name
  • No http.route attribute returned
@shaykeren shaykeren added the bug Something isn't working label May 19, 2022
@srikanthccv
Copy link
Member

What do you expect the span name if not empty?

@shaykeren
Copy link
Author

if an empty route has the same meaning of a route with a value of '/' then I would consider setting both the route and the name to '/'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants