Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FalconInstrumentor().uninstrument() method do not uninstrument existing Falcon Apps #1325

Closed
TheAnshul756 opened this issue Sep 12, 2022 · 3 comments · Fixed by #1341
Closed

FalconInstrumentor().uninstrument() method do not uninstrument existing Falcon Apps #1325

TheAnshul756 opened this issue Sep 12, 2022 · 3 comments · Fixed by #1341
Assignees
@TheAnshul756
Labels
bug Something isn't working

Comments

@TheAnshul756
Copy link
Contributor

Similar to #1256 in FastAPI, falcon uninstrument method do not uninstrument existing falcon instrumented apps, which is not the expected behaviour.
@TheAnshul756 TheAnshul756 added the bug Something isn't working label Sep 12, 2022
@TheAnshul756
Copy link
Contributor Author

@srikanthccv Please assign this to me.

@TheAnshul756
Copy link
Contributor Author

Hello @srikanthccv
Looks like there is no method to manually uninstrument an api/app in falcon similar to uninstrument_app in fastapi. Should I implement one, as it will be required to uninstrument existing instances?

@srikanthccv
Copy link
Member

To reduce the scope of this issue just add a private helper which can pop the middleware. The instrument_app/uninstrument_app can be a feature request to address in separate ticket.

@TheAnshul756 TheAnshul756 mentioned this issue Sep 19, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheAnshul756 TheAnshul756

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@srikanthccv @TheAnshul756