Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook to set custom span name in flask instrumentation #134

Closed
lzchen opened this issue Nov 3, 2020 · 0 comments
Closed

Add hook to set custom span name in flask instrumentation #134

lzchen opened this issue Nov 3, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation

Comments

@lzchen
Copy link
Contributor

lzchen commented Nov 3, 2020

Similar to wsgi, accept a callback function in FlaskInstrumentor().instrument to be able to pass custom span name.

The specs say "MAY" for this feature, but we should be consistent across our instrumentations.

Part of open-telemetry/opentelemetry-python#1297
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 5, 2020
@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Nov 5, 2020
@srikanthccv srikanthccv mentioned this issue Nov 6, 2020
Merged
@lzchen lzchen closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @lzchen