Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Falcon OpenTelemetry Instrumentation for Hug Web Framework #1726

Closed
mshebeko-twist opened this issue Mar 22, 2023 · 0 comments · Fixed by #1824
Closed

Improve Falcon OpenTelemetry Instrumentation for Hug Web Framework #1726

mshebeko-twist opened this issue Mar 22, 2023 · 0 comments · Fixed by #1824

Comments

@mshebeko-twist
Copy link
Contributor

Is your feature request related to a problem?
We are extensively using the Hug web framework in our organization. Since Hug is built on top of Falcon, we have been using the falcon-instrumentation library to instrument our applications. However, this approach results in spans that are difficult to interpret, as shown in the screenshot below:

Screen Shot 2023-03-22 at 11 03 16

Describe the solution you'd like
We believe that better instrumentation support for Hug can be achieved through one of the following options:

  • Develop a dedicated hug-instrumentation library, which would be largely similar (about 90%) to the existing falcon-instrumentation .
  • Create a hug-instrumentation library that depends on falcon-instrumentation and overrides some functions. However, this solution might be less maintainable and less readable.
  • Introduce a configuration option in the falcon-instrumentation library that enhances its compatibility with Hug.

Additional context
I have not personally tried the Falcon framework to see how spans are named there, but I assume they are similar to those of other frameworks. I would appreciate any input from project contributors on this matter and am willing to explore the issue further. What are your thoughts on the best approach to improve OpenTelemetry instrumentation for the Hug web framework?

@mshebeko-twist mshebeko-twist changed the title Improve OpenTelemetry Instrumentation for Hug Web Framework Improve Falcon OpenTelemetry Instrumentation for Hug Web Framework Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant