Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC client instrumentation is missing standard attributes #255

Closed
alertedsnake opened this issue Dec 14, 2020 · 1 comment
Closed

gRPC client instrumentation is missing standard attributes #255

alertedsnake opened this issue Dec 14, 2020 · 1 comment

Comments

@alertedsnake
Copy link
Contributor

As I worked on in #236, the client side of the gRPC instrumentation also needs to have a bunch more of the standard attributes defined in the spec added into each span, particularly the rpc ones.

I'm already working on a solution, but wanted to add an issue so others are aware.
@alertedsnake alertedsnake changed the title gRPC client telemetry is missing standard attributes gRPC client instrumentation is missing standard attributes Dec 14, 2020
@alertedsnake
Copy link
Contributor Author

This was handled in #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alertedsnake