Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC client instrumentation example doesn't run #256

Closed
alertedsnake opened this issue Dec 15, 2020 · 0 comments · Fixed by #269
Closed

gRPC client instrumentation example doesn't run #256

alertedsnake opened this issue Dec 15, 2020 · 0 comments · Fixed by #269
Labels
bug Something isn't working

Comments

@alertedsnake
Copy link
Contributor

The example in the gRPC instrumentation for the client side doesn't actually run as is.

Steps to reproduce
I copied the code into a Python file, made up some generated protobuf code for testing, and ran the program.

What is the expected behavior?

Greeter client received: YOU

What is the actual behavior?

  File "/tmp/client.py", line 42, in <module>
    run()
  File "/tmp/client.py", line 32, in run
    with grpc.insecure_channel("localhost:50051") as channel:
  File "/home/michael/work/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py", line 235, in __enter__
    raise NotImplementedError()
NotImplementedError

I'll probably work on this one too, since I need a test client to verify some of the other issues I'm already working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant