Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with aiopg 1.3.0 #561

Open
RyanSiu1995 opened this issue Jul 1, 2021 · 2 comments
Open

Integration with aiopg 1.3.0 #561

RyanSiu1995 opened this issue Jul 1, 2021 · 2 comments

Comments

@RyanSiu1995
Copy link
Contributor

RyanSiu1995 commented Jul 1, 2021

Is your feature request related to a problem?
Aiopg 1.3.0 has a breaking change on its internal Context Manager class.
The multiple classes were centralized into a single class called _ContextManager.
The constructor for _ContextManager was also changed accordingly.
Therefore, in order to integrate with aiopg 1.3.0, a further work is required.
Currently, PR #560 has forced the instrumentor not to instrument aiopg 1.3.0.
Before fixing the integration, the restriction will not be released.

Describe the solution you'd like
The best solution here will be a conditional import to support both aiopg 1.3.0 and aiopg < 1.3.0.
The conditional import can address the difference between 1.3.0 and < 1.3.0 in Context Manager and reconstruct the same property object.
The main logic then will share that object to run the code.
A set of new test cases under aiopg instrumentors should also be created to test against 1.3.0 and < 1.3.0.

@lcmartinezdev
Copy link

Sorry for that, is there any ETA on this?

@lzchen
Copy link
Contributor

lzchen commented Jul 20, 2022

@lcmartinezdev
There isn't anyone currently working on this. Feel free to open up a pr on this :)

@srikanthccv srikanthccv added the help wanted Extra attention is needed label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants