aiohttp instrumentation: Remove span_name from docs
#857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Param `span_name` already used in the docs! So let it works! ;) open-telemetry#848
lzchen
reviewed
Jan 11, 2022
Co-authored-by: Leighton Chen <lechen@microsoft.com>
|
@Olegt0rr please sign the CLA 👍 |
Also removed redundant `url_path_span_name` function, since it becomes unusable.
This reverts commit bbde08c.
Olegt0rr
changed the title
span_name from docs
lzchen
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
span_namefrom docsFixes #848
Type of change
How Has This Been Tested?
Not tested
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.