Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BaseException in record_exception #2652

Closed
kasium opened this issue Apr 29, 2022 · 2 comments · Fixed by #3354
Closed

Support BaseException in record_exception #2652

kasium opened this issue Apr 29, 2022 · 2 comments · Fixed by #3354
Assignees
@nstawski
Labels
feature-request

Comments

@kasium
Copy link
Contributor

kasium commented Apr 29, 2022

Is your feature request related to a problem?
If I want to record any exception, I need to use BaseException as the type. However, according to the signature of record_exception, only Exception is supported.

Describe the solution you'd like
Support BaseException in record_exception
@nstawski
Copy link
Contributor

I would like to take this issue.

@lzchen lzchen mentioned this issue Aug 17, 2023
Merged
11 tasks
@lzchen
Copy link
Contributor

lzchen commented Aug 17, 2023

@nstawski

Looks like there is already a pr out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nstawski nstawski

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

record_exception: Accept BaseException kamalmarhubi/opentelemetry-python
3 participants
@nstawski @lzchen @kasium