Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support instrumentation scope attributes #2940

Open
1 of 3 tasks
srikanthccv opened this issue Sep 20, 2022 · 2 comments
Open
1 of 3 tasks

Support instrumentation scope attributes #2940

srikanthccv opened this issue Sep 20, 2022 · 2 comments
Labels
api Affects the API package. feature-request good first issue Good first issue help wanted sdk Affects the SDK package.
Projects

Comments

@srikanthccv
Copy link
Member

srikanthccv commented Sep 20, 2022

  • Add optional scope attributes for tracer creation
  • Add optional scope attributes for meter creation
  • Add optional scope attributes for logger creation

and the attributes should not be part of meter/tracer/logger identity

@srikanthccv srikanthccv added api Affects the API package. sdk Affects the SDK package. feature-request labels Sep 20, 2022
@lzchen
Copy link
Contributor

lzchen commented Sep 21, 2022

Does this not apply to logs as well? Also the scope attributes should not be part of tracer identity either right?

@srikanthccv
Copy link
Member Author

You are correct about the identity part - updated the description. And as you know we don't have get_logger similar to get_{tracer,meter} since we don't have the API and it's implementation. I didn't include logs in the description for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the API package. feature-request good first issue Good first issue help wanted sdk Affects the SDK package.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants