adopt ruff?

[srikanthccv]

• fast
• autofixes
• monorepo friendly
• almost replacement for multiple linting packages

https://beta.ruff.rs/docs/

[lzchen]

Could be promising. Any risks for depending on a beta package for a linter though?

[srikanthccv]

It looks like several big projects have already started using it.

This may not replace everything, and we will probably run into some bummers. However, I hope this will improve the contributor experience because I have heard good things about it.

[aabmass]

After I sent out that draft, I collected feedback at the SIG and I think everyone wants to move forward with ruff. Here is my assessment of the tradeoffs

• Ruff does not use the python environment at all, so it no longer requires any deps to be installed in the virtualenv.
• This change keeps feature parity with flake8, isort, and black
• This does not keep feature parity with Pylint. See here for a list of tradeoffs and recommendations. I think this is a decent trade off given how clunky, difficult to use (e.g. Pylint is not actually checking some test files #3814), and slow pylint is.
• We should try to enable mypy on the rest of our sources to mitigate not running pylint

There have been numerous complaints about the painfully slow lint/formatting process on slack and the SIG calls lately.

I am sending out two separate PRs:

1. Migrating isort and black (auto formatting)
2. Migrating flake8 and pylint (linting)

[aabmass]

Since this will generate quite a bit of diffs, I am planning to add the commits to a .git-blame-ignore-revs file to not dirty up our history too much, see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view.