Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped Baggage entries in propagation still count against max entries #2071

Closed
Arnatious opened this issue Aug 25, 2021 · 0 comments · Fixed by #2079
Closed

Skipped Baggage entries in propagation still count against max entries #2071

Arnatious opened this issue Aug 25, 2021 · 0 comments · Fixed by #2079
Assignees
Labels
bug Something isn't working good first issue Good first issue help wanted

Comments

@Arnatious
Copy link
Contributor

Arnatious commented Aug 25, 2021

The decrement operation should be moved after the last continue block if the over-long entry is truly skipped, otherwise this behavior should probably be documented/tested for.

if total_baggage_entries <= 0:
return context
total_baggage_entries -= 1
if len(entry) > self._MAX_PAIR_LENGTH:
continue
try:
name, value = entry.split("=", 1)
except Exception: # pylint: disable=broad-except
continue

@lzchen lzchen added bug Something isn't working good first issue Good first issue help wanted labels Aug 27, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 30, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 30, 2021
@ocelotl ocelotl self-assigned this Aug 30, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good first issue help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants