Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Flask app #569

Closed
ocelotl opened this issue Apr 9, 2020 · 0 comments · Fixed by #570
Closed

Remove unnecessary Flask app #569

ocelotl opened this issue Apr 9, 2020 · 0 comments · Fixed by #570
Assignees
@ocelotl
Labels
bug Something isn't working doc Documentation-related instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Apr 9, 2020

The current auto instrumentation example includes an unnecessary Flask app in its client, remove that.
@ocelotl ocelotl added bug Something isn't working doc Documentation-related instrumentation Related to the instrumentation of third party libraries or frameworks labels Apr 9, 2020
@ocelotl ocelotl self-assigned this Apr 9, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 9, 2020
@ocelotl
Remove unnecessary Flask app
2bce126 
Fixes open-telemetry#569
@ocelotl ocelotl mentioned this issue Apr 9, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan @mayurkale22
chore: allow parent span to be null (open-telemetry#569)
b3332e3 
* chore: allow parent span to be null

* chore: revert nullish operator

* chore: return undefined for missing span

* test: undefined spans

* test: undefined spans
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore(plugin-mongodb-core): add missing codecov script (open-telemetr…
6e22fd5 
…y#601)

* chore(plugin-mongodb-core): add missing codecov script

* fix(mongodb-plugin): check currentSpan against undefined

* chore(scope-managers): return undefined if no scope is found (following open-telemetry#569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
bug Something isn't working doc Documentation-related instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary Flask app ocelotl/opentelemetry-python
1 participant
@ocelotl