Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update HTTP dependencie to ^1.0.0 #1476

Closed
janbraunsdorff opened this issue Jan 15, 2024 · 1 comment
Closed

[Feature]: Update HTTP dependencie to ^1.0.0 #1476

janbraunsdorff opened this issue Jan 15, 2024 · 1 comment
Labels
enhancement New feature or request triage:todo Needs to be traiged.

Comments

@janbraunsdorff
Copy link

Related Problems?

Hello,

I was wondering why some Documentation about Opentelemetry and hyper not working for me. It turns out, that opentelemety depends on http 0.2 and most of my other crate were updatet to http ^1.0.0 like hyper, hyper-body and axum.
Is there a plan to also increase the verion which opentelemetry depends on to 1.0.0.
Of course without braking other project or other issues?

Best regards

Describe the solution you'd like:

Opentelemetry is compatible with http ^1.0.0

Considered Alternatives

No response

Additional Context

Error Message:

HeaderMap and http::header::map::HeaderMap have similar names, but are actually distinct types
perhaps two different versions of crate http are being used?

  let ctx = opentelemetry::global::get_text_map_propagator(|pro| {
      pro.extract(&HeaderExtractor(request.headers()))
  });
@janbraunsdorff janbraunsdorff added enhancement New feature or request triage:todo Needs to be traiged. labels Jan 15, 2024
@TommyCpp
Copy link
Contributor

TommyCpp commented Jan 16, 2024

This seems to be duplicate with #1427

We were blocked on tonic when trying to upgrade to http 1.0 but I think we have an idea on how to upgrade now. Can track the progress there

@TommyCpp TommyCpp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage:todo Needs to be traiged.
Projects
None yet
Development

No branches or pull requests

2 participants