Remove ordered_float dependency #1761
Labels
A-metrics
Area: issues related to metrics
help wanted
Good for taking. Extra help will be provided by maintainers/approvers
Milestone
The SDK currently has a dependency on ordered_float. It is used to provide Hash, PartialEq implementations, for
F64
values. While the crate is very popular, it is still a 3rd party dependency, maintained under a personal account.Proposing to remove the dependency, and make
Hash
/PartialEq
implementation in theopentelemetry
crate itself, whereValue
is defined.The "correctness" part is not very important - i.e it is undefined if the following would get aggregated into a single metric point or not.
As a bonus, we can avoid the
HashKeyValue
wrapper aroundKeyValue
used in Metrics, which solely exist today to provide hash/partialeq implementations.The text was updated successfully, but these errors were encountered: