Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span lifetime / active span state #21

Closed
jtescher opened this issue Nov 27, 2019 · 2 comments
Closed

Span lifetime / active span state #21

jtescher opened this issue Nov 27, 2019 · 2 comments

Comments

@jtescher
Copy link
Member

Currently spans are stored in a thread local span stack, and either manually added and removed via mark_span_as_active / mark_span_as_inactive or for the scope of a given closure by using with_span.

This has certain drawbacks: spans marked as active and not later marked as inactive will not be dropped, marking as inactive is unexpected as it is not part of the spec, etc.

We should investigate if there are more reliable / intuitive / ergonomic ways of coordinating active span information between components. E.g. web framework middleware needing to set the active span for use later in the application.

@iredelmeier
Copy link
Member

See also #15 (I think they're related but separate)

@jtescher
Copy link
Member Author

jtescher commented Dec 7, 2019

Closing this in favor of #15

@jtescher jtescher closed this as completed Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants