Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: sanitization tweaks #928

Closed
dashpole opened this issue Dec 6, 2022 · 1 comment
Closed

Prometheus exporter: sanitization tweaks #928

dashpole opened this issue Dec 6, 2022 · 1 comment

Comments

@dashpole
Copy link

dashpole commented Dec 6, 2022

I would recommend adjusting the prefix logic during sanitization. Prometheus/OpenMetrics allow a metric to start with _, so there is no need to prefix a _ with key here. For metrics that start with a number, I would recommend prefixing with _ instead of key_ to match other implementations here.

@dashpole
Copy link
Author

dashpole commented Dec 6, 2022

Actually, reading this again https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#name, I don't think this advice is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant