Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define semantic conventions for timing metrics #1035

Open
jgals opened this issue Sep 29, 2020 · 1 comment
Open

Define semantic conventions for timing metrics #1035

jgals opened this issue Sep 29, 2020 · 1 comment
Assignees
@justinfoote
Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown

Comments

@jgals
Copy link

jgals commented Sep 29, 2020

What are you trying to achieve?
Documented semantic conventions for any generic timing measurement (e.g. latency, response time, throughput) along with labels that allow faceting by e.g. error.

What did you expect to see?
Semantic conventions for timing metrics documented in markdown generated from YAML definitions as per #547.

Additional context.
These should be roughly analogous to the trace semantic conventions for generic spans defined here. For reference, metric semantic conventions for HTTP operations are already defined here.
@jgals jgals added the spec:metrics Related to the specification/metrics directory label Sep 29, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Sep 29, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 2, 2020
@andrewhsu andrewhsu added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Oct 6, 2020
@andrewhsu andrewhsu added priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 16, 2020
@justinfoote justinfoote mentioned this issue Oct 23, 2020
Closed
@justinfoote
Copy link
Member

There are related issues:

This issue is sort of a duplicate of #654.
I've just created PR #1142, which is sort of a rewrite of the old PR #657.

@andrewhsu andrewhsu moved this from Required/Allowed for GA, todo. to Required/Allowed for GA, with linked PR. in GA Spec Burndown Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinfoote justinfoote

Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, with linked PR.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add semantic convention for timing durations justinfoote/opentelemetry-specification
4 participants
@andrewhsu @justinfoote @arminru @jgals