Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quantiles with Summary Metric for Amazon CloudWatch interoperability #1145

Closed
alolita opened this issue Oct 26, 2020 · 2 comments
Closed
Assignees
Labels
area:data-model For issues related to data model priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@alolita
Copy link
Member

alolita commented Oct 26, 2020

What are you trying to achieve?

We have a use case for reporting min, max and arbitrary quantile values (e.g. p99) recorded over an interval in the OTLP metrics.proto. Our use case was fully supported earlier by the Summary datatype which was removed in open-telemetry/opentelemetry-proto#199.

Currently there is no clean way of even reporting the min and max values, however that may become possible with issue 982. We additionally require support for reporting arbitrary quantiles.

What did you expect to see?

We would like a form of the Summary data type to be reintroduced into OTLP capable of supporting the reporting of arbitrary quantiles. When Summary was removed the change was described as temporary. What is the current timeline for its reintroduction?

Additional context.

As mentioned above we believe that a viable alternative for min/max may be to have them transported in the Histogram datatypes as one of the options in issue 982.

The other way we have considered it to encode them as exemplars in the histogram format. While possible for min and max

{
 0, // this is either the min or max ( min in this case)
 timestamp
},
{
 100, // this is either the min or max ( max in this case)
 timestamp
}

it seems less reasonable for arbitrary quantiles as we have no easy way of encoding which percentile the value corresponds to.

cc: @bogdandrutu @jmacd @tigrannajaryan @amanbrar1999 @JasonXZLiu

@alolita alolita added the spec:metrics Related to the specification/metrics directory label Oct 26, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:protocol Related to the specification/protocol directory area:miscellaneous For issues that don't match any other area label and removed spec:protocol Related to the specification/protocol directory labels Oct 27, 2020
@gcacace
Copy link

gcacace commented Oct 28, 2020

Proposal in open-telemetry/opentelemetry-proto#227

@andrewhsu andrewhsu added this to Required/Allowed for GA, todo. in GA Spec Burndown Oct 29, 2020
@jmacd jmacd added area:data-model For issues related to data model and removed area:miscellaneous For issues that don't match any other area label labels Feb 4, 2021
@weyert
Copy link

weyert commented Feb 23, 2021

Can't this ticket be closed as open-telemetry/opentelemetry-proto#227 got merged?

GA Spec Burndown automation moved this from Required/Allowed for GA, todo. to Required/Allowed for GA, resolved. Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Development

No branches or pull requests

6 participants