Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both push and pull based metrics at the same time #1207

Closed
sagikazarmark opened this issue Nov 7, 2020 · 2 comments
Closed

Support both push and pull based metrics at the same time #1207

sagikazarmark opened this issue Nov 7, 2020 · 2 comments
Assignees
@reyang
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown Spec - Metrics API/SDK Experimental R...
Milestone
Metrics API/SDK E...

Comments

@sagikazarmark
Copy link

What are you trying to achieve?

I'm trying to migrate an existing application from OpenCensus to OpenTelemetry. The application exposes metrics for Prometheus and pushes metrics to the OpenCensus collector. This is because some environments have an established monitoring solution in place using Prometheus and we never really moved to the collector entirely.

What did you expect to see?

I'd like to keep the same behavior with OpenTelemetry, but unfortunately it's not trivial at all. It looks like I can't use a push and a pull controller at the same time.

Additional context.

I asked about this on Gitter and was pointed to this repo to raise an issue about the question.

Discussion on Gitter: https://gitter.im/open-telemetry/opentelemetry-go?at=5fa08bda8d286f2076862eb8
@sagikazarmark sagikazarmark added the spec:metrics Related to the specification/metrics directory label Nov 7, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA area:sdk Related to the SDK labels Nov 10, 2020
@andrewhsu andrewhsu added this to Required/Allowed for GA, todo. in GA Spec Burndown Nov 10, 2020
@jmacd jmacd mentioned this issue Nov 12, 2020
Closed
@jmacd jmacd mentioned this issue Nov 30, 2020
Merged
@evankanderson
Copy link
Contributor

I'd like to do this, too. Is #1378 all that is required?

@jmacd jmacd removed their assignment Feb 4, 2021
@yorikya yorikya mentioned this issue Feb 16, 2021
Closed
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Mar 3, 2021
@reyang reyang self-assigned this Mar 3, 2021
@reyang reyang added this to To do in Spec - Metrics API/SDK Experimental Release via automation May 6, 2021
@reyang
Copy link
Member

reyang commented Jun 8, 2021

This is resolved by #1673.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricexporter

@reyang reyang closed this as completed Jun 8, 2021
GA Spec Burndown automation moved this from Required/Allowed for GA, todo. to Required/Allowed for GA, resolved. Jun 8, 2021
Spec - Metrics API/SDK Experimental Release automation moved this from To do to Done Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyang reyang

Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Spec - Metrics API/SDK Experimental R...
Done
Milestone
Metrics API/SDK Experimental Release
Development

No branches or pull requests
5 participants
@andrewhsu @sagikazarmark @jmacd @evankanderson @reyang