Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric names in specification don't match hostmetrics's paging scraper #2727

Open
crobert-1 opened this issue Aug 15, 2022 · 3 comments
Open

Metric names in specification don't match hostmetrics's paging scraper #2727

crobert-1 opened this issue Aug 15, 2022 · 3 comments
Assignees
@jmacd
Labels
spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@crobert-1
Copy link
Member

Metric names should be consistent between specification and receiver scrapers. The metrics in question are from the hostmetrics receiver, specifically the paging scraper: system.paging.operations.page_in and system.paging.operations.page_out. The specification incorrectly labels these as system.paging.operations.in and system.paging.operations.out. I believe the README and code are correct and the specification needs to be updated to match, but I'm open to correction here.

The mismatch appeared as a part of the direction attribute removal for the paging scraper.

Specification
hostmetrics receiver paging scraper README
Relevant code showing page_in and page_out
@crobert-1 crobert-1 added the spec:metrics Related to the specification/metrics directory label Aug 15, 2022
@rbailey7210 rbailey7210 added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Aug 19, 2022
@rbailey7210
Copy link

Thank you for reporting this. Would you be willing to follow-up?

@crobert-1
Copy link
Member Author

crobert-1 commented Aug 19, 2022 •
edited

I'm unsure how to proceed based on #2726. It looks like discussion is going on to may revert these changes and revisit the metric format change. Reverting the changed would resolve this issue.

I think it may be best to wait and see what happens with the metric format change as a whole before fixing.

@jmacd
Copy link
Contributor

jmacd commented Aug 19, 2022

Yes, it looks like we will revert all changes stemming from the change of "direction", which I think means reverting the name change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
spec:metrics Related to the specification/metrics directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmacd @rbailey7210 @crobert-1