Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getter used for Extraction #443

Closed
carlosalberto opened this issue Feb 5, 2020 · 2 comments
Closed

Update Getter used for Extraction #443

carlosalberto opened this issue Feb 5, 2020 · 2 comments
Milestone

Comments

@carlosalberto
Copy link
Contributor

From this comment in #424:

Jaeger context cannot be parsed using only the Getter interface. Here's an example of Jaeger context:

uber-trace-id: <some string, similar to W3C trace context>
uberctx-tenancy: test
uberctx-user: Yuri

The trace context has a fixed key name uber-trace-id, but baggage is encoded using variable header names uberctx-{baggage-key}.

Also, the W3C tracestate header may be split into multiple entries (repeated headers).

In the OpenTracing there was an iterator over all headers in order to handle this case, not just a Getter. Consider switching to an iterator-based approach.

@Oberon00
Copy link
Member

Oberon00 commented Feb 6, 2020

For the repeated-headers, aspect, see #433 (also discussed in the last SIG Spec call)

@carlosalberto
Copy link
Contributor Author

Closing this one on behalf of #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants