Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the metrics/api.md TODOs #598

Closed
jmacd opened this issue May 12, 2020 · 0 comments · Fixed by #601
Closed

Complete the metrics/api.md TODOs #598

jmacd opened this issue May 12, 2020 · 0 comments · Fixed by #601
Labels
spec:metrics Related to the specification/metrics directory
Milestone

Comments

@jmacd
Copy link
Contributor

jmacd commented May 12, 2020

The TODOs in specification/metric/api.md should be finished for the 0.5 spec milestone.

api.md�316:TODO: move and update content on metric names from api-user.md
api.md�608:TODO: specify detail on the metric instrument constructors from api-user.md
api.md�612:TODO: incorporate more detail on label sets from api-user.md
api.md�616:TODO: Organize a section on synchronous instruments from:
api.md�648:TODO: Organize a section on asynchronous instrument from:
api.md�655:TODO: This content will be re-organized into the sections dedicated to

Most of the missing content was already settled in earlier specification versions, but the documents needed to be restructured. The former content lies here:

https://github.com/open-telemetry/opentelemetry-specification/blob/494bb6dbd38d6d801871f34e9d141184b9e86d07/specification/metrics/api-user.md

The only parts of the spec that still need to be "settled" by these changes are related to asynchronous instrument calling conventions, which are under review:

open-telemetry/opentelemetry-go#717
#549

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label May 12, 2020
@jmacd jmacd added this to the v0.5 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
1 participant