Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: specify LastValue as default aggregation for ValueObserver instrument #834

Closed
jmacd opened this issue Aug 19, 2020 · 0 comments · Fixed by #984
Closed

Metrics: specify LastValue as default aggregation for ValueObserver instrument #834

jmacd opened this issue Aug 19, 2020 · 0 comments · Fixed by #984
Labels
area:api Cross language API specification issue area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown

Comments

@jmacd
Copy link
Contributor

jmacd commented Aug 19, 2020

What are you trying to achieve?

This has been widely discussed in both the Metrics SIG and in #636. There are lingering questions about ValueRecorder, but ValueObserver has been decided and agreed,

Additional context.

The API specification will state that LastValue is the default for ValueObserver.
@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Aug 19, 2020
@bogdandrutu bogdandrutu added area:api Cross language API specification issue area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Aug 19, 2020
@andrewhsu andrewhsu added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Aug 19, 2020
This was referenced Sep 10, 2020
Closed
Merged
@nilebox nilebox mentioned this issue Sep 14, 2020
Closed
This was referenced Sep 22, 2020
Closed
Merged
GA Spec Burndown automation moved this from Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. to Required for GA, done Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify LastValue for ValueObserver, TBD for ValueRecorder jmacd/opentelemetry-specification
2 participants
@bogdandrutu @jmacd