Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: refcache update policy and cron-job proposal #2554

Open
1 of 2 tasks
chalin opened this issue Mar 29, 2023 · 4 comments
Open
1 of 2 tasks

CI: refcache update policy and cron-job proposal #2554

chalin opened this issue Mar 29, 2023 · 4 comments
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Mar 29, 2023

@svrnm @cartermp @austinlparker: Severin brought up the topic of "burden on PR contributors" of having to update the refcache file. I'd like to propose the following.

  • If a PR introduces "lots" of new external links, then the PR must/should include an updated refcache file.
  • For other PRs, feel free to merge the PR whether the refcache is fresh or not -- freshness is checked via a separate GH action so it is possible to merge w/o the action passing.

We can then have, say, a cron job that periodically update the website's refcache file. WDYT?

Tasks

@chalin chalin added CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium labels Mar 29, 2023
@cartermp
Copy link
Contributor

I like it a lot.

@chalin
Copy link
Contributor Author

chalin commented Mar 29, 2023

I'd also like to propose the following tweak to the build script: it should fail (it doesn't currently), if there's an invalid link or if a new external link results in a 404 (independent of the refcache freshness). How does that sound?

@cartermp
Copy link
Contributor

Yep, works for me too. Can always tweak later if we need to.

@svrnm
Copy link
Member

svrnm commented Mar 29, 2023

+1 let's do that and improve from there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium
Projects
None yet
Development

No branches or pull requests

3 participants