Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is a "generic solution" for not duplicating spans still under construction? Is there any reference #2827

Open
svrnm opened this issue Jun 7, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed stale

Comments

@svrnm
Copy link
Member

svrnm commented Jun 7, 2023

On the page on native library instrumentation in the section Nested network and other spans the following is stated

WARNING: Generic solution to avoid duplication is under construction 🚧.

This has been there since #783, so I am wondering if this is resolved and we can update the documentation accordingly or if this is still under construction and if it is still under construction if there is a spec enhancement or OTEP that we can reference for that? @lmolkova @SergeyKanzhelev @austinlparker, sorry to ping you on this old matter but maybe someone of you can clarify?

@svrnm svrnm added the bug Something isn't working label Jun 7, 2023
@lmolkova
Copy link
Contributor

lmolkova commented Jun 7, 2023

It hasn't moved much since that.

You can find the history in open-telemetry/oteps#172 and mostly open-telemetry/opentelemetry-specification#1767 (and other issues mentioned in the OTEP).

TL;DR: each language has its own custom way. Java uses the proposal in the OTEP, JS, .NET and Python have APIs to suppress nested HTTP instrumentation on the scope of this call (sometimes they are internal and used within otel libs).

From the article's standpoint, we can either say that there is no generic solution, mention a few language-specific ones, leave it as is, or just say that native instrumentation should be cautious about it.

@svrnm
Copy link
Member Author

svrnm commented Jun 9, 2023

Thanks for the clarification, I'll think about a proper wording and update that accordingly.

@svrnm svrnm added the help wanted Extra attention is needed label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed stale
Projects
None yet
Development

No branches or pull requests

3 participants