Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk no longer in base opentelemetry crate #4365

Open
christiangil opened this issue Apr 25, 2024 · 3 comments
Open

sdk no longer in base opentelemetry crate #4365

christiangil opened this issue Apr 25, 2024 · 3 comments
Labels
bug Something isn't working sig:rust

Comments

@christiangil
Copy link
Contributor

What needs to be changed? If you try to run the example as is, you will get "error[E0433]: failed to resolve: could not find sdk in opentelemetry" on the lines:

use opentelemetry::sdk::trace::TracerProvider;
use opentelemetry::{global, sdk::propagation::TraceContextPropagator, trace::Tracer};

This can be fixed by replacing them with

use opentelemetry::{global, trace::Tracer};
use opentelemetry_sdk::propagation::TraceContextPropagator;
use opentelemetry_sdk::trace::TracerProvider;

and replacing the following in Cargo.toml

opentelemetry = { version = "0.21.0", features = ["trace"] }
opentelemetry-stdout = { version = "0.2.0", features = ["trace"] }

with

opentelemetry = "0.22"
opentelemetry_sdk = "0.22"
opentelemetry-stdout = { version = "0.3", features = ["trace"] }

What is the name + path of the page that needs changed? The Rust getting started page

@christiangil christiangil added the bug Something isn't working label Apr 25, 2024
@svrnm
Copy link
Member

svrnm commented Apr 26, 2024

thanks @christiangil ! Would you be interested in raising a PR for that (note that we require contributors to sign a CLA)

cc @open-telemetry/rust-approvers

@svrnm svrnm added the sig:rust label Apr 26, 2024
@christiangil
Copy link
Contributor Author

christiangil commented Apr 29, 2024

Sure, @svrnm I could do that! Should I wait to sign the CLA before making the PR?

@svrnm
Copy link
Member

svrnm commented Apr 29, 2024

Sure, @svrnm I could do that! Should I wait to sign the CLA before making the PR?

You will be asked to sign the CLA the moment you provide a PR, I am not 100% sure if you can sign it before (probably you can)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sig:rust
Projects
None yet
Development

No branches or pull requests

2 participants